fix: code quality review fixes#8
Merged
Merged
Conversation
… empty
build_managed_config was returning {} when tables=[], silently dropping
the schema name. A call like create_database("db", schema="analytics")
would send config: {} to the API and the schema declaration was lost.
Remove the early return so the schema block is always emitted. Add a
regression test for the empty-tables path.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The check was already present in _local_table_to_parquet with the same condition and message. Having it in create_table too was dead code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…cepted_result Every other HotdataClient created in this file is closed at the end of the test. This one was missed, leaving a dangling connection pool. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The method returns False for tables whose synced flag is False, which lets create_table proceed without overwrite=True while a load is still in progress. This was intentional but undocumented, making the behavior look like a bug. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…om_hotdata_sql_type ibis and sqlglot raise several different exception types depending on which part of type parsing fails (ValueError, AttributeError, parse errors internal to sqlglot). Narrowing to a specific type risks missing one and breaking type discovery for a valid-but-unusual column type. Add a comment so the broad catch is clearly deliberate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five separate commits addressing code quality review findings:
Test plan
🤖 Generated with Claude Code